ztr/TelegramPWA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Perf] Composer: Reduce redundant renders

Browse Source
This commit is contained in:
Alexander Zinchuk 2022-03-19 21:18:49 +01:00
parent 513444ec94
commit 1172e791e6
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/components/middle/composer/Composer.tsx
View File

@ -1,7 +1,7 @@
import React, { import React, {
FC, memo, useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState, FC, memo, useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState,
} from '../../../lib/teact/teact'; } from '../../../lib/teact/teact';
import { getDispatch, withGlobal } from '../../../lib/teact/teactn'; import { getDispatch, getGlobal, withGlobal } from '../../../lib/teact/teactn';
import { GlobalState, MessageListType } from '../../../global/types'; import { GlobalState, MessageListType } from '../../../global/types';
import { import {
@ -141,7 +141,6 @@ type StateProps =
shouldSuggestStickers?: boolean; shouldSuggestStickers?: boolean;
baseEmojiKeywords?: Record<string, string[]>; baseEmojiKeywords?: Record<string, string[]>;
emojiKeywords?: Record<string, string[]>; emojiKeywords?: Record<string, string[]>;
serverTimeOffset: number;
topInlineBotIds?: string[]; topInlineBotIds?: string[];
isInlineBotLoading: boolean; isInlineBotLoading: boolean;
inlineBots?: Record<string, false | InlineBotSettings>; inlineBots?: Record<string, false | InlineBotSettings>;
@ -204,7 +203,6 @@ const Composer: FC<OwnProps & StateProps> = ({
shouldSuggestStickers, shouldSuggestStickers,
baseEmojiKeywords, baseEmojiKeywords,
emojiKeywords, emojiKeywords,
serverTimeOffset,
recentEmojis, recentEmojis,
inlineBots, inlineBots,
isInlineBotLoading, isInlineBotLoading,
@ -508,6 +506,9 @@ const Composer: FC<OwnProps & StateProps> = ({
return; return;
} }
// No need to subscribe on updates in `mapStateToProps`
const { serverTimeOffset } = getGlobal();
const maxLength = currentAttachments.length ? CAPTION_MAX_LENGTH : MESSAGE_MAX_LENGTH; const maxLength = currentAttachments.length ? CAPTION_MAX_LENGTH : MESSAGE_MAX_LENGTH;
if (text?.length > maxLength) { if (text?.length > maxLength) {
const extraLength = text.length - maxLength; const extraLength = text.length - maxLength;
@ -584,7 +585,7 @@ const Composer: FC<OwnProps & StateProps> = ({
resetComposer(); resetComposer();
}); });
}, [ }, [
connectionState, attachments, activeVoiceRecording, isForwarding, clearDraft, chatId, serverTimeOffset, connectionState, attachments, activeVoiceRecording, isForwarding, clearDraft, chatId,
resetComposer, stopRecordingVoice, showDialog, slowMode, isAdmin, sendMessage, forwardMessages, lang, htmlRef, resetComposer, stopRecordingVoice, showDialog, slowMode, isAdmin, sendMessage, forwardMessages, lang, htmlRef,
]); ]);
@ -679,6 +680,9 @@ const Composer: FC<OwnProps & StateProps> = ({
const handleMessageSchedule = useCallback((date: Date, isWhenOnline = false) => { const handleMessageSchedule = useCallback((date: Date, isWhenOnline = false) => {
const { isSilent, ...restArgs } = scheduledMessageArgs || {}; const { isSilent, ...restArgs } = scheduledMessageArgs || {};
// No need to subscribe on updates in `mapStateToProps`
const { serverTimeOffset } = getGlobal();
// Scheduled time can not be less than 10 seconds in future // Scheduled time can not be less than 10 seconds in future
const scheduledAt = Math.round(Math.max(date.getTime(), Date.now() + 60 * 1000) / 1000) const scheduledAt = Math.round(Math.max(date.getTime(), Date.now() + 60 * 1000) / 1000)
+ (isWhenOnline ? 0 : serverTimeOffset); + (isWhenOnline ? 0 : serverTimeOffset);
@ -695,7 +699,7 @@ const Composer: FC<OwnProps & StateProps> = ({
}); });
} }
closeCalendar(); closeCalendar();
}, [closeCalendar, handleSend, resetComposer, scheduledMessageArgs, sendMessage, serverTimeOffset]); }, [closeCalendar, handleSend, resetComposer, scheduledMessageArgs, sendMessage]);
const handleMessageScheduleUntilOnline = useCallback(() => { const handleMessageScheduleUntilOnline = useCallback(() => {
handleMessageSchedule(new Date(SCHEDULED_WHEN_ONLINE * 1000), true); handleMessageSchedule(new Date(SCHEDULED_WHEN_ONLINE * 1000), true);
@ -1181,7 +1185,6 @@ export default memo(withGlobal<OwnProps>(
recentEmojis: global.recentEmojis, recentEmojis: global.recentEmojis,
baseEmojiKeywords: baseEmojiKeywords?.keywords, baseEmojiKeywords: baseEmojiKeywords?.keywords,
emojiKeywords: emojiKeywords?.keywords, emojiKeywords: emojiKeywords?.keywords,
serverTimeOffset: global.serverTimeOffset,
inlineBots: global.inlineBots.byUsername, inlineBots: global.inlineBots.byUsername,
isInlineBotLoading: global.inlineBots.isLoading, isInlineBotLoading: global.inlineBots.isLoading,
chatBotCommands: chat && chat.fullInfo && chat.fullInfo.botCommands, chatBotCommands: chat && chat.fullInfo && chat.fullInfo.botCommands,