[Perf] Middle Column / Pinned: Remove spinner in background (#2981)

This commit is contained in:
Alexander Zinchuk 2023-04-15 13:51:25 +02:00
parent ad9e1bb9a1
commit 180599f5d4
2 changed files with 9 additions and 7 deletions

View File

@ -105,12 +105,14 @@ const HeaderPinnedMessage: FC<OwnProps> = ({
ariaLabel={lang('EventLogFilterPinnedMessages')} ariaLabel={lang('EventLogFilterPinnedMessages')}
onClick={!shouldShowLoader ? onAllPinnedClick : undefined} onClick={!shouldShowLoader ? onAllPinnedClick : undefined}
> >
<Spinner {isLoading && (
color="blue" <Spinner
className={buildClassName( color="blue"
styles.loading, styles.pinListIcon, !shouldShowLoader && styles.pinListIconHidden, className={buildClassName(
)} styles.loading, styles.pinListIcon, !shouldShowLoader && styles.pinListIconHidden,
/> )}
/>
)}
<i <i
className={buildClassName( className={buildClassName(
'icon-pin-list', styles.pinListIcon, shouldShowLoader && styles.pinListIconHidden, 'icon-pin-list', styles.pinListIcon, shouldShowLoader && styles.pinListIconHidden,

View File

@ -270,7 +270,7 @@ const MiddleHeader: FC<OwnProps & StateProps> = ({
const { const {
shouldRender: shouldRenderPinnedMessage, shouldRender: shouldRenderPinnedMessage,
transitionClassNames: pinnedMessageClassNames, transitionClassNames: pinnedMessageClassNames,
} = useShowTransition(Boolean(pinnedMessage)); } = useShowTransition(Boolean(pinnedMessage), undefined, true);
const renderingPinnedMessage = useCurrentOrPrev(pinnedMessage, true); const renderingPinnedMessage = useCurrentOrPrev(pinnedMessage, true);
const renderingPinnedMessagesCount = useCurrentOrPrev(pinnedMessagesCount, true); const renderingPinnedMessagesCount = useCurrentOrPrev(pinnedMessagesCount, true);