ztr/TelegramPWA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "[Perf] Story Toggler: Avoid expensive global updates on users and chats"

Browse Source 
This reverts commit 9ab1f9d9789a211140b692e49dac7237d3718edf.
This commit is contained in:
Alexander Zinchuk 2024-09-06 15:43:26 +02:00
parent 342a3d92da
commit 458f71a555
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/components/story/StoryToggler.tsx
View File

@ -1,6 +1,7 @@
import React, { memo, useEffect, useMemo } from '../../lib/teact/teact';
import { getActions, getGlobal, withGlobal } from '../../global';
import { getActions, withGlobal } from '../../global';
import type { ApiChat, ApiUser } from '../../api/types';
import type { GlobalState } from '../../global/types';
import { ANIMATION_END_DELAY, PREVIEW_AVATAR_COUNT } from '../../config';
@ -27,6 +28,8 @@ interface StateProps {
isShown: boolean;
isForumPanelOpen?: boolean;
withAnimation?: boolean;
usersById: Record<string, ApiUser>;
chatsById: Record<string, ApiChat>;
peerStories: GlobalState['stories']['byPeerId'];
}
@ -35,6 +38,8 @@ const PRELOAD_PEERS = 5;
function StoryToggler({
currentUserId,
orderedPeerIds,
usersById,
chatsById,
canShow,
isShown,
isForumPanelOpen,
@ -47,10 +52,6 @@ function StoryToggler({
const lang = useOldLang();
const peers = useMemo(() => {
// No need for expensive global updates on users, so we avoid them
const usersById = getGlobal().users.byId;
const chatsById = getGlobal().chats.byId;
if (orderedPeerIds.length === 1) {
return [usersById[orderedPeerIds[0]] || chatsById[orderedPeerIds[0]]];
}
@ -60,7 +61,7 @@ function StoryToggler({
.filter((peer) => peer && peer.id !== currentUserId)
.slice(0, PREVIEW_AVATAR_COUNT)
.reverse();
}, [currentUserId, orderedPeerIds]);
}, [currentUserId, orderedPeerIds, usersById, chatsById]);
const closeFriends = useMemo(() => {
if (!peers?.length) return {};
@ -145,6 +146,8 @@ export default memo(withGlobal<OwnProps>((global, { isArchived }): StateProps =>
isShown: isArchived ? !isArchivedRibbonShown : !isRibbonShown,
isForumPanelOpen,
withAnimation,
usersById: global.users.byId,
chatsById: global.chats.byId,
peerStories: byPeerId,
};
})(StoryToggler));