From 94b5c311032020a2fb0eb4b9d113bf82e4e5ad4b Mon Sep 17 00:00:00 2001 From: Alexander Zinchuk Date: Mon, 6 Nov 2023 01:43:00 +0400 Subject: [PATCH] Electron: Sanitize application version during update check (#3933) --- src/util/getIsAppUpdateNeeded.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/getIsAppUpdateNeeded.ts b/src/util/getIsAppUpdateNeeded.ts index c0878c408..23f5ab1a2 100644 --- a/src/util/getIsAppUpdateNeeded.ts +++ b/src/util/getIsAppUpdateNeeded.ts @@ -1,5 +1,7 @@ const APP_VERSION_REGEX = /^\d+\.\d+(\.\d+)?$/; export default function getIsAppUpdateNeeded(remoteVersion: string, appVersion: string) { - return APP_VERSION_REGEX.test(remoteVersion) && remoteVersion !== appVersion; + const sanitizedRemoteVersion = remoteVersion.trim(); + + return APP_VERSION_REGEX.test(sanitizedRemoteVersion) && sanitizedRemoteVersion !== appVersion; }