ztr/TelegramPWA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Teact: Fix key = 0 in fast lists

Browse Source
This commit is contained in:
Alexander Zinchuk 2021-12-10 18:32:27 +01:00
parent 27b3cdbd6f
commit dee7d2163f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/teact/teact-dom.ts
View File

@ -273,7 +273,8 @@ function renderFastListChildren($current: VirtualRealElement, $new: VirtualRealE
$new.children.map(($newChild) => {
const key = 'props' in $newChild && $newChild.props.key;
if (DEBUG && isRealElement($newChild) && !key) {
// eslint-disable-next-line no-null/no-null
if (DEBUG && isRealElement($newChild) && (key === undefined || key === null)) {
// eslint-disable-next-line no-console
console.warn('Missing `key` in `teactFastList`');
}
@ -286,13 +287,15 @@ function renderFastListChildren($current: VirtualRealElement, $new: VirtualRealE
const remainingByKey = $current.children
.reduce((acc, $currentChild, i) => {
let key = 'props' in $currentChild ? $currentChild.props.key : undefined;
// eslint-disable-next-line no-null/no-null
const isKeyPresent = key !== undefined && key !== null;
// First we handle removed children
if (key && !newKeys.has(key)) {
if (isKeyPresent && !newKeys.has(key)) {
renderWithVirtual(currentEl, $currentChild, undefined, $new, -1);
return acc;
} else if (!key) {
} else if (!isKeyPresent) {
const $newChild = $new.children[i];
const newChildKey = ($newChild && 'props' in $newChild) ? $newChild.props.key : undefined;
// If a non-key element remains at the same index we preserve it with a virtual `key`